-
Couldn't load subscription status.
- Fork 10.5k
[IMP] developer: explain the new <asset> tag added as a fix #15007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@qsm-odoo while this was properly forward-ported, at least one co-dependent PR (odoo/odoo#233118, odoo/enterprise#98108, odoo/design-themes#1173) did not succeed. You will need to fix it before this can be merged. Both this PR and the others will need to be approved via More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Also removes outdated things in the `<template>` tag documentation and reviews it a bit. See odoo/odoo#104836 task-2963840 X-original-commit: 4a6611b
781f53f to
0f7b43f
Compare
|
@AntoineVDV Would you approve/delegate here? 🙏 No conflict, rebuilt in local, seems good 👍 |
|
Don't you have r+ rights in your forward-ports automatically ? 🤔 robodoo delegate+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delegate probably useless, but I am guessing I still need the approval or does this say I can approve myself too?

Let's see:
@robodoo r+
|
Indeed, delegate+ is useless since it'd give rights to the fw-port bot 🤦♂️. |
|
@qsm-odoo This is the generic merge requirement set on this GitHub project (similar to odoo/odoo) so that people don't click that big green button at the bottom of the page, but mergebot doesn't care about it. |
|
@qsm-odoo linked pull request(s) odoo/design-themes#1173, odoo/enterprise#98108, odoo/odoo#233118 not ready. Linked PRs are not staged until all of them are ready. |
|
@qsm-odoo linked pull request(s) odoo/odoo#233118 not ready. Linked PRs are not staged until all of them are ready. |
*: test_website, base, web_editor, website, website_blog, website_event,
website_mail_group, website_mass_mailing, website_payment,
website_sale, test_assetsbundle
Before this commit when a module was updated all ir.asset records were
reset to their defined `active` state, if defined.
This causes assets related to old snippet versions to be made inactive
even if those old snippet versions are used inside existing pages.
It used to work when the activation of assets was made through view
inheritance because when views are defined through a `<template>` tag,
the `active` attribute is in fact ignored during updates since [1],
except for new records since [2].
This commit introduces an `<asset>` tag in the XML import format.
It is an alias of `<record ... model="ir.asset">` with the additional
feature that it avoids taking the `active` field into account during
updates for existing `ir_asset` records, just like `<template>` if the
`active` field is mentioned as attribute of the tag.
We then rely on the `website_disable_unused_snippets_assets` cron to
properly disable any unused asset at a later stage (note that the bug
being fixed here was mitigated by the fact that cron also re-enabled
assets which were disabled by mistake... but that might happen only a
few days later).
Another approach was to overload `_load_records_write` in `base`'s
`ir_asset.py` to avoid taking the `active` field into account when
updating records:
```py
def _load_records_write(self, values):
values.pop('active', None)
super()._load_records_write(values)
```
But this is not as stable because it changes the way `ir.asset` records
are imported when the `<record>` tag is used. In the end we chose to be
consistent and do exactly the same as `<template>`, as this also allows
more and should be entirely stable.
[1]: 2d296cb#diff-175c28787c272a219b9275f79262a48af9aa029e718f45077fd609737559e84eR803-R804
[2]: f1c70d4#diff-175c28787c272a219b9275f79262a48af9aa029e718f45077fd609737559e84eR801-R804
task-2963840
closes #233118
X-original-commit: 58c75d0
Related: odoo/enterprise#98108
Related: odoo/documentation#15007
Related: odoo/design-themes#1173
Signed-off-by: Quentin Smetz (qsm) <[email protected]>
Co-authored-by: qsm-odoo <[email protected]>
*: theme_anelusia, theme_artists, theme_avantgarde, theme_aviato, theme_beauty, theme_bewise, theme_bistro, theme_bookstore, theme_buzzy, theme_clean, theme_cobalt, theme_enark, theme_graphene, theme_kea, theme_kiddo, theme_loftspace, theme_monglia, theme_nano, theme_notes, theme_odoo_experts, theme_orchid, theme_paptic, theme_real_estate, theme_test_custo, theme_treehouse, theme_vehicle, theme_yes, theme_zap See community commit for details. task-2963840 closes #1173 X-original-commit: e46be95 Related: odoo/odoo#233118 Related: odoo/enterprise#98108 Related: odoo/documentation#15007 Signed-off-by: Quentin Smetz (qsm) <[email protected]> Co-authored-by: qsm-odoo <[email protected]>
Also removes outdated things in the `<template>` tag documentation and reviews it a bit. See odoo/odoo#104836 task-2963840 closes #15007 X-original-commit: 4a6611b Related: odoo/odoo#233118 Related: odoo/enterprise#98108 Related: odoo/design-themes#1173 Signed-off-by: Quentin Smetz (qsm) <[email protected]>

See odoo/odoo#104836
task-2963840
Forward-Port-Of: #14984